Is gperf really needed when building the JSCOnly with CMake?

# Koby Boyango (2 days ago)

I'm currently experimenting with using the new Azure Pipelines as the CI platform for node-jsc. While setting up the Windows test, I had to add some extra steps in order to add gperf and make sure CMake's find_package finds it. Currently, gperf is required for all CMake ports, as it is checked in WebKitCommon.cmake. But searching the WebKit repo, it seems that it's only used when building WebCore, making it unnecessary for the JSCOnly port (which is by node-jsc). So, do you think it could be excluded from JSCOnly port's dependencies?

Thanks, Koby

Contact us to advertise here
# Michael Catanzaro (2 days ago)

Yeah, I'd just put it in an if (NOT ${PORT} STREQUAL "JSCOnly")

(writing that off the top of my head, probably somehow wrong)

# Konstantin Tokarev (2 days ago)
# Michael Catanzaro (a day ago)

On Sun, Sep 30, 2018 at 7:29 PM, Konstantin Tokarev <annulen at yandex.ru>

wrote:

Or, better, if (ENABLE_WEBCORE)

Yeah, that's better

Want more features?

Request early access to our private beta of readable email premium.