JSC EWS being too optimistic

# Caio Lima (6 days ago)

I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are marking every patch as success, even if there is a build failure (see bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for bugs.webkit.org/show_bug.cgi?id=202140). Is it already in someone's radar?If not, could anybody take a look on this? I tried to investigate, but I'm lacking knowledge of EWS code base. This already caused some noise into JSC patches that broke ARMv7 and MIPS ports. I opened this bug to report it bugs.webkit.org/show_bug.cgi?id=202419.

Thanks in advance, Caio Lima.

Contact us to advertise here
# Aakash Jain (6 hours ago)

Thanks for reporting this issue.

Jonathan fixed the bug you reported (bugs.webkit.org/show_bug.cgi?id=202419, bugs.webkit.org/show_bug.cgi?id=202419). It was a regression from a recent change.

I verified the fix using the same patch you tested with earlier. jsc EWS is now (correctly) failing on that patch (bugs.webkit.org/show_bug.cgi?id=202140, bugs.webkit.org/show_bug.cgi?id=202140). Please let me know if you notice any issue.

Thanks Aakash

# Caio Lima (6 hours ago)

Thank you very much for this fix!

BR, Caio.

Em qua, 9 de out de 2019 às 12:35, Aakash Jain <aakash_jain at apple.com> escreveu:

Want more features?

Request early access to our private beta of readable email premium.