Reducing globals

# Alex Christensen (6 days ago)

I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!

Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in trac.webkit.org/changeset/238654/webkit and trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow.

Contact us to advertise here
# Claudio Saavedra (5 days ago)

On Thu, 2018-11-29 at 18:15 -0800, Alex Christensen wrote:

I am embarking on a journey to reduce the number of global variables and singletons we use instead member variables on the proper objects. Feel free to join!

Specifically, I’m looking into reducing the number of members in the NetworkProcessCreationParameters structure. Many of them need to go to NetworkSessionCreationParameters instead. Could those maintaining the libsoup and libcurl networking implementations please lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)? I have done similar moves in trac.webkit.org/changeset/238654/webkit and trac.webkit.org/changeset/238630/webkit if you would like a pattern to follow.

Thanks for the reference. I'll have a look at the libsoup members whenever I have some time.

Claudio

# Basuke.Suzuki at sony.com (2 days ago)

Alex,

Got it. Curl port will catch up this move soon.

I just want to confirm my understanding about Network Session. It is pretty similar concept with Cocoa's URLSession, isn't it?

Curl Port uses default NetworkSession at everywhere so that it is almost same with global NetworkProcess. We need to move forward to support NetworkSession correctly.


Basuke Suzuki SONY PlayStation

# Alex Christensen (2 days ago)

On Dec 3, 2018, at 12:55 PM, Basuke.Suzuki at sony.com wrote:

Alex,

Got it. Curl port will catch up this move soon.

Great! Thanks!

I just want to confirm my understanding about Network Session. It is pretty similar concept with Cocoa's URLSession, isn't it?

It tries.

Want more features?

Request early access to our private beta of readable email premium.