WebKit Commit Queue blocked by build errors in ToT

# Chris Fleizach (18 hours ago)

Looks like Commit Queue is blocked on processing patches because of a build failure that's been there for a day


webkit-queues.webkit.org/results/10296999 In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:27: /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:229:40: error: unknown type name 'SafeBrowsingWarning'; did you mean 'WKSafeBrowsingWarning'? void showSafeBrowsingWarning(const SafeBrowsingWarning&, CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&&); ^~~~~ WKSafeBrowsingWarning /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:56:12: note: 'WKSafeBrowsingWarning' declared here OBJC_CLASS WKSafeBrowsingWarning; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:1619:19: error: out-of-line definition of 'showSafeBrowsingWarning' does not match any declaration in 'WebKit::WebViewImpl' void WebViewImpl::showSafeBrowsingWarning(const SafeBrowsingWarning& warning, CompletionHandler<void(Variant<ContinueUnsafeLoad, URL>&&)>&& completionHandler) ^~~~~ /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2801:22: error: instance method '-dismiss' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] [_shareSheet dismiss];

                 ^~~~~~~

Filed a bug to track: bugs.webkit.org/show_bug.cgi?id=192479

Contact us to advertise here
# Ryan Haddad (17 hours ago)

Chris,

I'm assuming that this is in reference to the patch in bugs.webkit.org/show_bug.cgi?id=192373, bugs.webkit.org/show_bug.cgi?id=192373. My guess is that something about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with unified sources.

The commit-queue itself has been landing other patches without issue and the build isn't broken on trunk bots. CC'ing Tim in case he can help point out the issue.

Ryan

# Chris Fleizach (17 hours ago)

On Dec 6, 2018, at 4:37 PM, Ryan Haddad <ryanhaddad at apple.com> wrote:

Chris,

I'm assuming that this is in reference to the patch in bugs.webkit.org/show_bug.cgi?id=192373, bugs.webkit.org/show_bug.cgi?id=192373. My guess is that something about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with unified sources.

The commit-queue itself has been landing other patches without issue and the build isn't broken on trunk bots. CC'ing Tim in case he can help point out the issue.

Yea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to another folder (from Mac -> Cocoa)

# Andy Estes (17 hours ago)

On Dec 6, 2018, at 4:37 PM, Chris Fleizach <cfleizach at apple.com> wrote:

On Dec 6, 2018, at 4:37 PM, Ryan Haddad <ryanhaddad at apple.com <mailto:ryanhaddad at apple.com>> wrote:

Chris,

I'm assuming that this is in reference to the patch in bugs.webkit.org/show_bug.cgi?id=192373, bugs.webkit.org/show_bug.cgi?id=192373. My guess is that something about the changes to Source/WebKit/WebKit.xcodeproj/project.pbxproj is causing an issue with unified sources.

The commit-queue itself has been landing other patches without issue and the build isn't broken on trunk bots. CC'ing Tim in case he can help point out the issue.

Yea must be. Any ideas why this wouldn’t build? I moved this .h/.mm to another folder (from Mac -> Cocoa)

Looks like we need to forward-declare class WebKit::SafeBrowsingWarning in WebViewImpl.h. Can you try that in your patch and see if that fixes it?

Andy

# Chris Fleizach (17 hours ago)

On it

# Chris Fleizach (an hour ago)

I'm hitting this tougher one now. Namespace conflict between Rect in Carbon and WebCore::Rect

Any ideas? Thanks for your help

n file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:6: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:32: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/Shared/Plugins/Netscape/NetscapePluginModule.h:34: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npruntime_internal.h:28: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/npapi.h:82: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Headers/Carbon.h:29: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbox.h:35: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbar.h:26: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Menus.h:22: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/Appearance.h:1373:3: error: reference to 'Rect' is ambiguous Rect bounds; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/WebKit2Prefix.h:45: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:43: In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFBase.h:77: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/MacTypes.h:550:41: note: candidate found by name lookup is 'Rect' typedef struct Rect Rect; ^ In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource28-mm.mm:1: In file included from /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:95: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/PrivateHeaders/Rect.h:60:7: note: candidate found by name lookup is 'WebCore::Rect' class Rect final : public RectBase, public RefCounted<Rect> { ^

# Tim Horton (an hour ago)

Someone in UnifiedSource28-mm.mm is “using namespace WebCore” outside of the root namespace.

# Chris Fleizach (an hour ago)

Looks like there's quite a few of these. Will try to get them all

# Chris Fleizach (an hour ago)

To confirm, this is what is expected? Is WebKit the root namespace?

namespace WebKit { using namespace WebCore; using namespace WebKit;

# Tim Horton (43 minutes ago)

On Dec 7, 2018, at 08:55, Chris Fleizach <cfleizach at apple.com> wrote:

To confirm, this is what is expected? Is WebKit the root namespace?

namespace WebKit { using namespace WebCore; using namespace WebKit;

No, that’s fine. It would be outside of that.

Want more features?

Request early access to our private beta of readable email premium.